Skip to content

Comments

feat: pg ssl certificate support for event streams user#1483

Open
ttuffin wants to merge 1 commit intomainfrom
event_stream_db_support_mtls
Open

feat: pg ssl certificate support for event streams user#1483
ttuffin wants to merge 1 commit intomainfrom
event_stream_db_support_mtls

Conversation

@ttuffin
Copy link
Contributor

@ttuffin ttuffin commented Feb 18, 2026

Adding support for postgresl SSL certificates for the event streams database user. This allows the user to specify a SSL certificate and key strictly for the event streams database user.

Related to ongoing work in https://issues.redhat.com/browse/AAP-65135.

Adding support for postgresl SSL certificates for
the event streams database user.
@ttuffin ttuffin force-pushed the event_stream_db_support_mtls branch from 38e7b55 to 177c3c4 Compare February 18, 2026 20:04
@ttuffin
Copy link
Contributor Author

ttuffin commented Feb 18, 2026

/run-e2e

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.44%. Comparing base (1d7e5b2) to head (177c3c4).

@@           Coverage Diff           @@
##             main    #1483   +/-   ##
=======================================
  Coverage   91.44%   91.44%           
=======================================
  Files         235      235           
  Lines       10135    10140    +5     
=======================================
+ Hits         9268     9273    +5     
  Misses        867      867           
Flag Coverage Δ
unit-int-tests-3.11 91.44% <100.00%> (+<0.01%) ⬆️
unit-int-tests-3.12 91.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...da/core/management/commands/create_initial_data.py 98.07% <100.00%> (+0.02%) ⬆️
src/aap_eda/settings/defaults.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@ttuffin
Copy link
Contributor Author

ttuffin commented Feb 19, 2026

@ttuffin ttuffin marked this pull request as ready for review February 19, 2026 10:20
@ttuffin ttuffin requested a review from a team as a code owner February 19, 2026 10:20
@ttuffin ttuffin requested a review from mkanoor February 19, 2026 10:20
# Use dedicated event stream credentials only if both username
# and password are defined, otherwise use default DB credentials.
if settings.EVENT_STREAM_DB_USER and settings.EVENT_STREAM_DB_PASSWORD:
# use TLS certs if provided
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ttuffin There is an ssl_mode field will that have to be kept in sync with certain auth parameters. If we inherit the ssl_mode from EDA DB access if the user doesn't provide the EVENT_STREAM_DB_SSLCERT and EVENT_STREAM_DB_SSLKEY would we fail the startup or will the installer ensure that based on the ssl_mode we have the correct set of required parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants