Open
Conversation
zkayyali812
force-pushed
the
zk/platform-flags
branch
from
e6a1dac to
61eb4e3
Compare
10 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1346 +/- ##
=======================================
Coverage 93.91% 93.92%
=======================================
Files 320 320
Lines 18827 18843 +16
=======================================
+ Hits 17682 17698 +16
Misses 1145 1145
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
zkayyali812
force-pushed
the
zk/platform-flags
branch
from
61eb4e3 to
09fb407
Compare
|
zkayyali812
force-pushed
the
zk/platform-flags
branch
from
09fb407 to
4aeb9d1
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/AAP-45879
This PR moves the EDA feature flag source from Settings based feature flags, to platform database level feature flags.
This also makes gateway the provider of this data for the platform.
This is required to enable platform level feature flags.
Gateway is the provider of the feature flag value updates, and is resource synced to EDA/other components.
It can be validated and tested simply with AAP Dev, and requires the following DAB PR to be merged in beforehand -
ansible/django-ansible-base#736
Once the DAB PR is merged, I will update this PR to point back to the upstream
develbranch of DABTo test -