Make the down.sh script exclude cleaning up CRDs by default#292
Open
rooftopcellist wants to merge 1 commit intoansible:mainfrom
Open
Make the down.sh script exclude cleaning up CRDs by default#292rooftopcellist wants to merge 1 commit intoansible:mainfrom
rooftopcellist wants to merge 1 commit intoansible:mainfrom
Conversation
rooftopcellist
force-pushed
the
down-script-keep-crds
branch
5 times, most recently
from
a5be672 to
552f21d
Compare
rooftopcellist
force-pushed
the
down-script-keep-crds
branch
from
552f21d to
ca8d912
Compare
|
Alex-Izquierdo
approved these changes
Jul 11, 2025
Contributor
Alex-Izquierdo
left a comment
Alex-Izquierdo
left a comment
There was a problem hiding this comment.
LGTM, should we document it in https://github.com/ansible/eda-server-operator/blob/main/docs/development.md#clean-up ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Without this change, by default, the down.sh will delete all EDA related CRD's on the cluster. If there are other EDA operators on the cluster or the AAP Operator is in another namespace on this cluster, this could clobber the CRD for all. To avoid that, I am changing the default behavior so that it keeps the CRD's. Optionally, you can pass the
--allflag to delete them as well.Details
Added --all flag to down.sh
This PR adds an optional --all flag to the down.sh script that controls whether CRDs are removed during cleanup.
Usage:
This change helps developers who need a complete cleanup of their environment, while maintaining backward compatibility with the existing workflow.