Skip to content

Fix TypeScript 5.9.3 Uint8Array type compatibility issues #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankoh merged 4 commits into from
Feb 3, 2026
Merged

Fix TypeScript 5.9.3 Uint8Array type compatibility issues #1532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4e0394
Initial plan
Copilot Feb 3, 2026
db1818a
Enable TypeScript 5.9.3 compatibility with skipLibCheck and esModuleI…
Copilot Feb 3, 2026
0773c58
Fix TypeScript 5.9.3 Uint8Array type errors by using .buffer property
Copilot Feb 3, 2026
e7d87a0
Use type assertions instead of .buffer to preserve Uint8Array data size
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dashql-app/src/platform/native_grpc_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export class NativeGrpcChannel {
const request = new Request(url, {
method: 'POST',
headers,
body: args.body,
body: args.body as BodyInit,
});
const response = await fetch(request);
await throwIfError(response);
Expand Down
2 changes: 1 addition & 1 deletion packages/dashql-app/src/platform/native_http_client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export class NativeHttpClient implements HttpClient {
this.logger.debug(`fetch http stream`, { "remote": remote, "path": input?.toString() }, "native_http_client");

const body: any = init?.body;
let bodyBuffer: ArrayBuffer;
let bodyBuffer: ArrayBuffer | Uint8Array;
if (init?.body) {
if (init.body instanceof ArrayBuffer) {
bodyBuffer = init.body;
Expand Down
2 changes: 1 addition & 1 deletion packages/dashql-app/src/platform/web_file_downloader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { FileDownloader } from './file_downloader.js';
export class WebFileDownloader implements FileDownloader {
async downloadBufferAsFile(uint8Array: Uint8Array, filename: string): Promise<void> {
// Create a Blob from the Uint8Array
const blob = new Blob([uint8Array], { type: 'application/octet-stream' });
const blob = new Blob([uint8Array as BlobPart], { type: 'application/octet-stream' });
// Create a temporary URL for the Blob
const url = URL.createObjectURL(blob);
// Create an anchor element and trigger the download
Expand Down