Skip to content

Conversation

@david-allison
Copy link
Member

Approach

How Has This Been Tested?

Brief test:

Google Pixel 9 Pro

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@ericli3690 ericli3690 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I forgot this file existed, thanks for applying the viewbinding update!!

I think AddEditReminderDialog is also lacking viewbinding, I'll switch it over when I rebase and revise my threshold filters advanced options PR unless you'd like to do so first (in which case, please let me know and then be my guest!)

@david-allison
Copy link
Member Author

david-allison commented Jan 12, 2026

AddEditReminderDialog is not on my list as far as I see. Happy for you to take it on!

@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Review labels Jan 15, 2026
@lukstbit lukstbit added this pull request to the merge queue Jan 15, 2026
Merged via the queue into ankidroid:main with commit 38fd25b Jan 15, 2026
19 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jan 15, 2026
@github-actions github-actions bot added this to the 2.24 release milestone Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants