Fix false positive for add_reference with foreign_key option validate as false. #313
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lse }
When using `add_reference` with `foreign_key: { validate: false }`, the
check incorrectly warns that "Adding a foreign key blocks writes on both
tables" even though `validate: false` makes it safe.
The fix updates `check_add_reference` to inspect whether the foreign_key
option contains `validate: false`, similar to how `check_add_foreign_key`
already handles this case.
Owner
|
Hi @j4rs, thanks for the PR. The code looks good, but please remove the version bump and changelog date. |
j4rs
force-pushed
the
add-validate-option-to-add-reference-foreign-key
branch
from
bcee50b to
4a33d40
Compare
Owner
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add_referencewithforeign_key: { validate: false }validate: falsemakes it safecheck_add_referencewithcheck_add_foreign_key, which already handlesvalidate: falsecorrectlyExample
test_foreign_key_validate_false