This repository was archived by the owner on May 5, 2020. It is now read-only.
Optimising String access for efficient usage using enums#356
Open
vatsalkul wants to merge 1 commit intoanitab-org:developfrom
Open
Optimising String access for efficient usage using enums#356vatsalkul wants to merge 1 commit intoanitab-org:developfrom
vatsalkul wants to merge 1 commit intoanitab-org:developfrom
Conversation
Made enums in order to access strings
Contributor
|
I’m still thinking about this. The enum naming is not ideal. |
Member
Author
|
As I gone through the Strings.swift file, I also noticed that there is a scope of organising strings in the related groups. After all, It depends upon the developer what kind of style they want to follow. 😇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have organised the constants in Utilities/Strings.swift into appropriate enums.
It will result in efficient access and identification of data throughout the app.
Fixes #222
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
All the functionality of app is working and tased on iPhone simulator.
Checklist:
Code/Quality Assurance Only