Skip to content

Conversation

@gramound
Copy link

Android Studio's built-in jbr is based on openjdk 21.0.8

Fix: #192

Android Studio's built-in jbr is based on openjdk 21.0.8

Fix: android#192
@gemini-code-assist
Copy link

Summary of Changes

Hello @gramound, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's build configuration to align with JVM toolchain and target version 21. This change is motivated by Android Studio's built-in Java Runtime Environment (JBR) being based on OpenJDK 21.0.8, ensuring better compatibility and allowing the project to leverage the latest Java features and performance enhancements.

Highlights

  • JVM Toolchain Update: The Kotlin JVM toolchain has been updated from version 17 to 21 in both JetStreamCompose/benchmark/build.gradle.kts and JetStreamCompose/jetstream/build.gradle.kts.
  • JVM Target Update: The Kotlin JVM target has been updated from version 17 to 21 in JetStreamCompose/jetstream/build.gradle.kts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the JVM toolchain from 17 to 21 across the JetStream project. This is a good change to keep the project aligned with modern development environments like Android Studio. The changes are applied correctly. I have one suggestion for jetstream/build.gradle.kts to remove a redundant kotlinOptions block, as its configuration is now automatically handled by the jvmToolchain setting. This will help improve the build script's clarity and maintainability.

Comment on lines 69 to 71
kotlinOptions {
jvmTarget = "17"
jvmTarget = "21"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The jvmTarget is automatically inferred from the jvmToolchain setting. Since you've set jvmToolchain(21) on line 27, this kotlinOptions block is redundant and can be safely removed. This will make the build script cleaner and less prone to configuration mismatches in the future.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I added it as a second commit on the same branch (to be squashed at the end).

Removed redundant jvmTarget

Fix: android#192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JetStream: gradle sync fails with the latest Android Studio

1 participant