-
Notifications
You must be signed in to change notification settings - Fork 388
Use jvmToolchain 21 for JetStream #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Android Studio's built-in jbr is based on openjdk 21.0.8 Fix: android#192
Summary of ChangesHello @gramound, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's build configuration to align with JVM toolchain and target version 21. This change is motivated by Android Studio's built-in Java Runtime Environment (JBR) being based on OpenJDK 21.0.8, ensuring better compatibility and allowing the project to leverage the latest Java features and performance enhancements. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the JVM toolchain from 17 to 21 across the JetStream project. This is a good change to keep the project aligned with modern development environments like Android Studio. The changes are applied correctly. I have one suggestion for jetstream/build.gradle.kts to remove a redundant kotlinOptions block, as its configuration is now automatically handled by the jvmToolchain setting. This will help improve the build script's clarity and maintainability.
| kotlinOptions { | ||
| jvmTarget = "17" | ||
| jvmTarget = "21" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I added it as a second commit on the same branch (to be squashed at the end).
Removed redundant jvmTarget Fix: android#192
Android Studio's built-in jbr is based on openjdk 21.0.8
Fix: #192