Updated to void safety for first review #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It requires an updated version of the graph library not yet in SVN. In latest version of the graph library was an redesign done that makes this library generate an error when compiling: Error code: VDRD(2) Type error: redeclaration has non-conforming signature. What to do: make sure that redeclaration uses signature (number and types of arguments and result) conforming to that of the original. Class: MA_OBJECT_NODE Redefined feature: model: detachable EG_NODE From: MA_OBJECT_NODE Precursor: model: EG_LINKABLE From: EG_LINKABLE_FIGURE
Owner
Author
There was a problem hiding this comment.
It seems like a larger cvhange but mainly it is only an if-statement added
if attached grid...
instead of the check.
…iffel graph library, available at "https://github.com/Conaclos/EG-complete-safe".
Adapt memory analyzer to both soft and advanced redesign of EG library
Victorien want to test with latest version of graph library update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires an updated version of the graph library not yet in SVN.
In latest version of the graph library was a redesign done that makes
this library generate an error when compiling:
Error code: VDRD(2)
Type error: redeclaration has non-conforming signature.
What to do: make sure that redeclaration uses signature (number and
types of arguments and result) conforming to that of the original.
Class: MA_OBJECT_NODE
Redefined feature: model: detachable EG_NODE From: MA_OBJECT_NODE
Precursor: model: EG_LINKABLE From: EG_LINKABLE_FIGURE
My main concern is if the changes are ok from a backward compatible perspective and if they are ok for the none void safe builds. It build in none void safe mode but do we loose some controlls, like preconditions when using attached instead of /= Void.
Some diffs are large due to that I introduced new if-statements. github-diff does not seem to handle that in a good way. It looked better in SVN. Might be that I need to set something like "ignore white space changes" but I can not find that setting in github.