Skip to content

Conversation

@japauliina
Copy link

@japauliina japauliina commented Mar 4, 2025

Upgrade Node to v20

  • Upgrade node in steps to v20.
  • Remove unused packages.
  • Replace node-sass with sass
  • Upgrade Jest.
  • Upgrade packages without breaking changes to the latest versions.

See TTVA-241 & TTVA-242 for changes that are related but will be done later.

Refs TTVA-226, TTVA-236

@japauliina japauliina force-pushed the TTVA-226-node-upgrade branch from 4c91b34 to e591f61 Compare March 7, 2025 08:11
Refs TTVA-236
Node Sass is no longer supported. Replace it with sass as recommended
by the authors.

Refs TTVA-236
Refs TTVA-236
Refs TTVA-236
UserReservationsPage test fails when run with test:ci command. Skip it
for now.

Refs TTVA-236, TTVA-241
Refs TTVA-236, TTVA-242
Refs TTVA-236, TTVA-242
Upgrade packages without breaking changes to the latest versions.

Refs TTVA-236, TTVA-242
@japauliina japauliina force-pushed the TTVA-226-node-upgrade branch from e591f61 to 54af4b0 Compare March 7, 2025 09:07
@japauliina japauliina requested a review from jopesy March 7, 2025 11:51
import ReservationList from '../reservation-list/ReservationListContainer';

describe('pages/user-reservations/UserReservationsPage', () => {
xdescribe('pages/user-reservations/UserReservationsPage', () => {
Copy link

@jopesy jopesy Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test (or whatever causes it to fail) should be fixed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit with a fix.

Refs TTVA-236, TTVA-241
Copy link

@jopesy jopesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@jorilindell jorilindell force-pushed the TTVA-226-node-upgrade branch from d460cbc to b707e5f Compare December 18, 2025 10:53
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.58%. Comparing base (538b418) to head (00ab217).
⚠️ Report is 24 commits behind head on tre-qa.

Files with missing lines Patch % Lines
...servations/reservation-list/ReservationListItem.js 66.66% 1 Missing ⚠️
src/domain/resource/card/ResourceCard.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           tre-qa     #153      +/-   ##
==========================================
+ Coverage   75.28%   75.58%   +0.29%     
==========================================
  Files         282      283       +1     
  Lines        6503     6574      +71     
  Branches     1819     1867      +48     
==========================================
+ Hits         4896     4969      +73     
+ Misses       1427     1426       -1     
+ Partials      180      179       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants