[zod-mock]: add recursion depth control feature#262
Open
akkonrad wants to merge 1 commit intoanatine:mainfrom
Open
[zod-mock]: add recursion depth control feature#262akkonrad wants to merge 1 commit intoanatine:mainfrom
akkonrad wants to merge 1 commit intoanatine:mainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 67e7cfb
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: Prevent infinite recursion in zod-mock with levelLimit option
packages/zod-mockSummary
Adds a recursion guard to
generateMockto prevent infinite loops for self-referential schemas. Introduces a new optionlevelLimit(default: 1) to control how many times the same schema instance can expand along a single generation path.Motivation
Self-referential schemas (e.g., via
z.lazy) could cause infinite recursion during mock generation. This change provides a safe default and a configurable limit to support controlled depth.Changes
levelLimit?: numbertoGenerateMockOptions(default = 1).__levelsMap__?: WeakMap<ZodTypeAny, number>to track per-call expansion counts.undefinedwhen the limit is exceeded at a specific node to stop further expansion.levelLimitis increased.README.mdwith examples.Usage
Backwards Compatibility
Tests
Documentation
packages/zod-mock/README.mdwith a new section describinglevelLimit, rationale, and examples.If there’s a preferred default depth or alternative handling strategy (e.g., truncating with a sentinel value), I can adjust accordingly.