-
Notifications
You must be signed in to change notification settings - Fork 45
0.8.12 #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.8.12 #788
Conversation
* Fix plot * Updates for torch.GradScaler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @roman-kh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request appears to be part of the preparation for version 0.8.12. It includes minor updates to documentation, a small adjustment for PyTorch compatibility in the model base class, and a fix for the plotting module's cleanup logic to ensure proper object removal.
Highlights
- Documentation Update: Updated the GitHub Actions status badge URL format in the README.
- PyTorch Compatibility: Adjusted the initialization of
torch.GradScalerin the base PyTorch model class, changingtorch.cuda.amp.GradScaler()totorch.GradScaler("cuda"). - Plotting Cleanup Fix: Corrected the order of operations in the
Plotter.clear()method to ensure layer objects are removed before the axes are cleared.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be a version bump to 0.8.12. It includes a badge URL update in the README, a minor reordering of operations in the plot.py's Subplot.clear method, and a change to GradScaler instantiation in batchflow/models/torch/base.py.
The most significant change is the modification to GradScaler, which unfortunately introduces a runtime error. This needs to be addressed. The other changes seem fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updating internal utilities and CI configurations to align with newer APIs and streamline workflows:
- Reorder Plotter’s clear logic to run
ax.clear()after object removals - Switch to the new
GradScalerconstructor signature and refresh the CI badge URL - Enhance the GitHub Actions matrix trigger logic and remove duplicated test steps in CI
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| batchflow/plotter/plot.py | Move self.ax.clear() below object removal in clear() |
| batchflow/models/torch/base.py | Update GradScaler instantiation to the new top‐level API |
| README.md | Fix GitHub Actions status badge path |
| .github/workflows/test-install.yml | Add workflow_dispatch, conditional matrix, and dedupe test steps |
Comments suppressed due to low confidence (3)
.github/workflows/test-install.yml:205
- This CI step is duplicated; removing the second instance will avoid running identical tests twice and simplify the workflow.
- name: Run basic tests
batchflow/plotter/plot.py:861
- Calling
Axes.clear()already removes all artists, making the prior loop overobj.remove()redundant. Consider dropping the explicit removal loop or movingclear()before removals to avoid unnecessary iterations.
self.ax.clear()
batchflow/models/torch/base.py:686
- Passing "cuda" positionally is interpreted as
init_scale, not the device. Usetorch.cuda.amp.GradScaler()ortorch.GradScaler(device="cuda")to ensure the scaler is initialized on the GPU.
self.scaler = torch.GradScaler("cuda")
No description provided.