Skip to content

Conversation

@AlexeyKozhevin
Copy link
Member

@AlexeyKozhevin AlexeyKozhevin commented Feb 4, 2025

  • poetry -> uv
  • pylint -> ruff
  • Replace nvidia_smi with pynvml
  • torch.cuda.amp.autocast -> torch.amp.autocast
  • Remove tests for python 3.8 and add 3.12
  • Updates for numpy>=2.0

TODO:

  • Remove all pylint: disable -> next time with updates for ruff to be sure that old checks are valid
  • Update github workflow for linter and tests
  • Update github workflow for installation (add UV)
  • Update github workflow for release

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AlexeyKozhevin AlexeyKozhevin changed the title Packages Updates for new numpy, torch and python >= 3.12 Feb 5, 2025
@AlexeyKozhevin AlexeyKozhevin marked this pull request as ready for review February 5, 2025 10:46
@@ -0,0 +1,9 @@
line-length = 120
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not have this file (ruff.toml) as part of the pyproject.toml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to separate setup tools from check tools.

@AlexeyKozhevin AlexeyKozhevin merged commit edb39d8 into master Feb 18, 2025
49 checks passed
@AlexeyKozhevin AlexeyKozhevin deleted the packages branch February 18, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants