Conversation
|
I wonder which Gutenberg change caused this. I only found WordPress/gutenberg#16813 so far that could be relevant. That PR also makes me wonder how/if we're going to implement that same feature in the future... 🤔 |
Yep, that's the PR that caused the change. I'm thinking that since right now we will release before the new feature comes out then the Inserter should look OK in both cases, that's why maybe it wouldn't make sense to move over to the new style and markup right now fully. However, for 1.2.2 we could apply the changes, we could also then consider changing the classnames so that we wouldn't be influenced by upstream changes. Thoughts? |
* tag '1.2.1': (434 commits) Bump 1.2.1 Adjust block inserter style. (#3075) Update dependency eslint-plugin-jest to v22.15.2 Fix flaky CTA test (#3057) Add more resizing handles (#3023) Bump version to 1.2.1-RC1 Improve story page background media with image srcset, reduced image size, and a11y text (#3006) Wait until content loaded before calculating font size. (#3052) Harden logic for normalizing image metadata before adding story images (#3049) Update dependency uuid to v3.3.3 (#3046) Inline color support (#3033) Update dependency webpack-cli to v3.3.7 (#3040) Tiny prop-types fix Update dependency babel-jest to v24.9.0 (#3037) Update e2e test setup (#3031) Include amp-script among dynamic_element_selectors in tree shaking Another try to fix tests. Ensure selecting the first page before removing the block. Move setting input selection to the end to helpers. Fix editor test. ...
3 participants
Fixes #3062.
Before:
After:
