Open
Conversation
timbyr
force-pushed
the
cloudprovider-node-list
branch
from
c798393 to
6311ab4
Compare
This will allow cloud providers to access ExternalID and ProviderID as hostnames can be inconsistent in clouds such as OpenStack.
timbyr
force-pushed
the
cloudprovider-node-list
branch
from
6311ab4 to
2a27ef4
Compare
| return nil | ||
| } | ||
|
|
||
| hosts := hostsFromNodeList(nodes) |
There was a problem hiding this comment.
Function call signature does not match: hostsFromNodeList(nodes)
Function call definition: *func HostsFromNodeList(list api.NodeList) []string {}
Author
There was a problem hiding this comment.
There is a local function hostsFromNodeList(nodes) in servicecontroller.go
There was a problem hiding this comment.
hostsFromNodeList() is only ever called after building up a NodeList using getNodeConditionPredicate() which check in the node is Unschedulable...
So (line 635-637) in hostsFromNodeList to is now redundant:
if list.Items[ix].Spec.Unschedulable {
continue
}
And can be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.