Skip to content

Add support for ruby 3 #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alejandrodevs wants to merge 4 commits into
base: 3.1
Choose a base branch
from
Open

Add support for ruby 3 #187

alejandrodevs wants to merge 4 commits into from

Conversation

@alejandrodevs
Copy link
Contributor

@alejandrodevs alejandrodevs commented Jan 4, 2022 •
edited
Loading

Actions:

  • Use SimpleDelegator instead DelegateClass.

@alejandrodevs alejandrodevs self-assigned this Jan 4, 2022
@alejandrodevs alejandrodevs force-pushed the remove-depracations-and-fix-tests branch from 062c487 to cd574d7 Compare January 4, 2022 22:57
@alejandrodevs alejandrodevs changed the title Use SimpleDelegator instead DelegateClass to support ruby 3 Add support for ruby 3 Jan 4, 2022
ErickFabian
ErickFabian reviewed Jan 4, 2022
View reviewed changes
lib/dolly/collection.rb

module Dolly
class Collection < DelegateClass(Array)
class Collection < SimpleDelegator
Copy link
Contributor

@ErickFabian ErickFabian Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no issue with previous versions of ruby with this change?

Copy link
Contributor Author

@alejandrodevs alejandrodevs Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It behaves the same and SimpleDelegator is available since ruby 2.4 if I'm not wrong.

Copy link
Member

@brlanier brlanier Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this changes rules out some versions of Ruby, then that should be reflected in the version... This should probably be done on a new branch or something as it would be a breaking change for applications using older rubies

ErickFabian
ErickFabian approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@ErickFabian ErickFabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

brlanier
brlanier reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@brlanier brlanier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

lib/dolly/collection.rb

module Dolly
class Collection < DelegateClass(Array)
class Collection < SimpleDelegator
Copy link
Member

@brlanier brlanier Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this changes rules out some versions of Ruby, then that should be reflected in the version... This should probably be done on a new branch or something as it would be a breaking change for applications using older rubies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brlanier brlanier brlanier left review comments

+1 more reviewer

@ErickFabian ErickFabian ErickFabian approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@alejandrodevs alejandrodevs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alejandrodevs @brlanier @ErickFabian