remove StackName from CW event rule target id #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove StackName from "sfRealTimeQueueMetricsCron.target"
martin-greenberg
previously approved these changes
Oct 17, 2022
seiyako
previously approved these changes
Oct 27, 2022
srivanc
dismissed stale reviews from seiyako and martin-greenberg
We can't merge this as customers could have multiple SF lambdas in their account so they need this disambiguator
|
@srivanc This is absolutely not true, ID is only identifying target within same rule and this each alarm has separate targets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove AWS::StackName pseudo parameter from "sfRealTimeQueueMetricsCron.targets.1"
Description of changes:
when deploying this package as a nested stack it failed due to 64 characters limit
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.