release-3.1.0 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove button visibility
…ng state, and improve scroll button styles
…ncies; upgrade vite version
…nd clarify samesite policy
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the codebase for the upcoming release 3.1.0 by updating security settings, refining UI styling, and enhancing chat component behavior. Key changes include:
- Updating cookie security settings in the API routes.
- Adjustments to CSS for improved styling of chat components.
- Enhancements to chat components (ChatMessageUser, ChatMessageBot, ChatInput) including new loading state and input validations.
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/api/routes.py | Updated cookie attributes for secure and samesite values. |
| client/src/main.css | Modified CSS for scrollbar colors, chat container positioning and class name updates. |
| client/src/components/chat/ChatMessageUser.jsx | Added new component to display user messages. |
| client/src/components/chat/ChatMessageBot.jsx | Renamed and reorganized bot message component imports. |
| client/src/components/chat/ChatLayout.jsx | Updated to use new chat message components and integrated loading state. |
| client/src/components/chat/ChatInput.jsx | Enhanced input behavior with maxLength enforcement, error handling, and icon update. |
| client/src/components/LogoutPop.jsx | Minor styling adjustments for logout dialog. |
Files not reviewed (1)
- client/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
client/src/components/chat/ChatInput.jsx:38
- [nitpick] Verify whether reducing maxRows from 8 to 7 is intentional as it may affect the visibility of the input area for multi-line messages.
maxRows={7}
| secure=False, # TODO: Set to True in production with HTTPS | ||
| samesite='Lax', # TODO: Set to 'Lax' in production with HTTPS | ||
| secure=True, # TODO: Set to True in production with HTTPS | ||
| samesite="Lax", # TODO: Set to 'Lax' in production with HTTPS or 'None' for cross-site |
There was a problem hiding this comment.
The inline comment for samesite suggests alternative configurations; consider clarifying the intended production setup to avoid ambiguity.
Comment on lines
+45
to
+46
| error={inputText.length > 11999} | ||
| helperText={inputText.length > 11999 ? "Input too long, max 12000 length supported" : ""} |
There was a problem hiding this comment.
[nitpick] Consider defining a constant for the maximum input length instead of using the magic number 12000 to improve maintainability.
Suggested change
| error={inputText.length > 11999} | |
| helperText={inputText.length > 11999 ? "Input too long, max 12000 length supported" : ""} | |
| error={inputText.length > MAX_INPUT_LENGTH - 1} | |
| helperText={inputText.length > MAX_INPUT_LENGTH - 1 ? `Input too long, max ${MAX_INPUT_LENGTH} length supported` : ""} |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release-3.1.0