Correctly encoding arrays for GET requests

[ghost]

Description

Fixes #220

Users were required to convert arrays of strings to comma-separated lists manually, for them to work as parameters in GET requests.
With this fix, the qs library properly encodes arrays as comma-separated lists of values.

Changes for this pull request

• Added arrayFormat: 'comma' to the options passed to qs.stringify
• Added the relevant test case for this behavior

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tsolakoua]

Thanks so much for the contribution to the library @gpembark! It looks great, but I have a question. Is it a backward compatible change? Would it affect the already existing users that were building the comma-separated lists manually?

[ghost]

Hi @tsolakoua! It shouldn't break for two reasons:

• the new parameter only applies to encoding arrays, it doesn't change anything it how it was encoding other stuff (and a comma-separated string should just be a string as far as that function is concerned)
• I assumed so because all the other tests are still passing 😅

Happy to add a specific test case if you prefer, let me know.

[tsolakoua]

Sounds great @gpembark, thanks a lot for the clear explanation and the contribution :)