Update HPDF library to latest compiler #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring fork up to date with library
Updated stack.yaml resolver to lts-13.6 Fixed Readme file name error in cabal file Fixed an error in Graphics.PDF.Draw where returned elements of a list were assumed to have a head, and this was not guaranteed Removed redundant imports Added top-level type signatures where they did not exist Added explicit ignores of parser elements that were skipped Tidied syntax of some simple parsers Fixed places where type inference caused warnings Fixed orphaned instances (by moving the data type declaration) Fixed places where names shadowed existing instances
|
Great work, thanks! Have you considered taking over this package officially? |
nomeata
added a commit
to nomeata/HPDF
that referenced
this pull request
Mar 6, 2019
this is based on 1.4.10, to allow upgrading without using depending code. alpheccar#23 contains more comprehensive upgrades to the latest, never released version of HPDF on github.
|
i see there are a lot of PRs piled up, solving some of the same problems. are they ever getting merged? do you have write access @nomeata ? |
I don’t have … and don't want to, ideally :-) |
sorry, got myself a bit confused. |
|
Fixed in 1.5.0 |
|
Should this be closed then, @ScottSedgwick? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I pulled HPDF into a new project I was working on and it threw a compile error, because it is a bit behind the latest compiler version. (The error was in line 255 of Graphics/PDF/Draw.hs)
So I brought my fork up to date with your repo, updated to the most recent stack version, and fixed all the errors and warnings. This is the result.
Thanks for all your work on this, I use this library quite a bit.
Regards,
Scott.