Skip to content

refactor: update recommendation date fields for consistency #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gsamuya merged 1 commit into from
Jan 29, 2026
Merged

refactor: update recommendation date fields for consistency #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions cover/v1/cover.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1538,11 +1538,8 @@ message ExecuteRecommendationV3Response {
message ListRecommendationsV3Request {
string costgroupId = 1;
repeated string statuses = 2;
optional string lastDetectedStartDate = 3;
optional string lastDetectedEndDate = 4;
optional string dateDetectedStartDate = 5;
optional string dateDetectedEndDate = 6;

optional string dateStart = 3;
optional string dateEnd = 4;
}

message RecommendationSummary {
Expand Down
10 changes: 2 additions & 8 deletions openapiv2/apidocs.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41842,16 +41842,10 @@
"type": "string"
}
},
"lastDetectedStartDate": {
"dateStart": {
"type": "string"
},
"lastDetectedEndDate": {
"type": "string"
},
"dateDetectedStartDate": {
"type": "string"
},
"dateDetectedEndDate": {
"dateEnd": {
"type": "string"
}
}
Expand Down
Loading