Draft
Conversation
…ws, specifically those involving `LoopCombinatorStep`. Before this commit, `LoopCombinatorStep` terminated only when all input ports received an `IterationTerminationToken` containing the iteration's prefix tag and a `TerminationToken`. Now, the `RECOVERED` status can be used within a `TerminationToken` to trigger termination for every step execution (including `LoopCombinatorStep`), behaving similarly to `CANCELLED` and `FAILED` statuses. Note that while the internal termination is triggered by `RECOVERED`, the step propagates a `TerminationToken` with `Status.COMPLETED` to the output ports. This ensures that the logic for abrupt termination is managed by the recovery workflow structure (e.g., via `InterWorkflowPort` boundary rules) rather than the step itself.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #958 +/- ##
==========================================
- Coverage 73.66% 73.64% -0.03%
==========================================
Files 90 90
Lines 12223 12228 +5
Branches 2161 2163 +2
==========================================
+ Hits 9004 9005 +1
- Misses 2704 2706 +2
- Partials 515 517 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces
Status.RECOVEREDto support recovery workflows, specifically those involvingLoopCombinatorStep.Before this commit,
LoopCombinatorStepterminated only when all input ports received anIterationTerminationTokencontaining the iteration's prefix tag and aTerminationToken. Now, theRECOVEREDstatus can be used within aTerminationTokento trigger termination for every step execution (includingLoopCombinatorStep), behaving similarly toCANCELLEDandFAILEDstatuses. (logic within_reduce_statusesfunction)Note that while the internal termination is triggered by
RECOVERED, the step propagates aTerminationTokenwithStatus.COMPLETEDto the output ports (logic within_get_statusmethod). This ensures that the logic for abrupt termination is managed by the recovery workflow structure (e.g., viaInterWorkflowPortboundary rules) rather than the step itself.