Open
Conversation
GlassOfWhiskey
force-pushed
the
improve-remote-command-part-2
branch
from
9e1c782 to
9d313f1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #955 +/- ##
==========================================
- Coverage 73.66% 73.62% -0.04%
==========================================
Files 90 90
Lines 12223 12225 +2
Branches 2161 2160 -1
==========================================
- Hits 9004 9001 -3
- Misses 2704 2707 +3
- Partials 515 517 +2 ☔ View full report in Codecov by Sentry. |
GlassOfWhiskey
force-pushed
the
improve-remote-command-part-2
branch
26 times, most recently
from
84468a4 to
f3494d2
Compare
This commit further improves command quoting in StreamFlow `Command` and `Connector` classes by properly using `mslex` and `shlex` utilities. In addition, this commit removes the last base64 encryption leftovers.
GlassOfWhiskey
force-pushed
the
improve-remote-command-part-2
branch
from
f3494d2 to
7094a66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit further improves command quoting in StreamFlow
CommandandConnectorclasses by properly usingmslexandshlexutilities.