Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #952 +/- ##
==========================================
+ Coverage 73.66% 73.69% +0.02%
==========================================
Files 90 90
Lines 12223 12224 +1
Branches 2161 2160 -1
==========================================
+ Hits 9004 9008 +4
+ Misses 2704 2702 -2
+ Partials 515 514 -1 ☔ View full report in Codecov by Sentry. |
271d236 to
972e366
Compare
LoopCombinatorStepLoopCombinator
…sibility to combine tokens with different tag levels (a state that should never occur in loop). Most importantly, this change also resolves potential errors in recovery workflows where input tokens may arrive out of order. Before this commit, during recovery, an output token could have the correct tag while its associated input tokens were incorrect due to tag mismatches (e.g., a token with tag `0.0` was generated using input tokens with tags `[0, 0.0, 0]`).
972e366 to
465b58e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves
LoopCombinatorperformance by skipping the possibility to combine tokens with different tag levels (a state that should never occur in loops). Most importantly, this change also resolves potential errors in recovery workflows where input tokens may arrive out of order. Before this commit, during recovery, an output token could have the correct tag while its associated input tokens were incorrect due to tag mismatches (e.g., a token with tag0.0was generated using input tokens with tags[0, 0.0, 0]).Moreover, the
restoremethod of theLoopCombinatorandLoopCombinatorStepclasses was refactored.