Implemented template validation in the CommandTemplateMap class#916
Open
LanderOtto wants to merge 2 commits intomasterfrom
Open
Implemented template validation in the CommandTemplateMap class#916LanderOtto wants to merge 2 commits intomasterfrom
CommandTemplateMap class#916LanderOtto wants to merge 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #916 +/- ##
==========================================
+ Coverage 73.46% 73.54% +0.07%
==========================================
Files 91 91
Lines 12257 12266 +9
Branches 2160 2162 +2
==========================================
+ Hits 9005 9021 +16
+ Misses 2742 2737 -5
+ Partials 510 508 -2 ☔ View full report in Codecov by Sentry. |
LanderOtto
force-pushed
the
feat/template-check
branch
from
2b03119 to
a954bb2
Compare
LanderOtto
changed the title
Template class.Template class
LanderOtto
changed the title
Template classCommandTemplateMap class
LanderOtto
force-pushed
the
feat/template-check
branch
from
a954bb2 to
b2baa3a
Compare
GlassOfWhiskey
force-pushed
the
master
branch
4 times, most recently
from
8c05dac to
4a6edc9
Compare
…reamflow_command` placeholder
LanderOtto
force-pushed
the
feat/template-check
branch
from
b2baa3a to
1aff220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a validation on the templates in the
CommandTemplateMapclass. The templates must include thestreamflow_commandplaceholder