Fixed retrieving disk information in SingularityConnector#894
Open
LanderOtto wants to merge 2 commits intomasterfrom
Open
Fixed retrieving disk information in SingularityConnector#894LanderOtto wants to merge 2 commits intomasterfrom
SingularityConnector#894LanderOtto wants to merge 2 commits intomasterfrom
Conversation
…tion if parent already exists.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #894 +/- ##
==========================================
+ Coverage 72.73% 72.96% +0.23%
==========================================
Files 90 91 +1
Lines 12089 12226 +137
Branches 2125 2158 +33
==========================================
+ Hits 8793 8921 +128
+ Misses 2808 2800 -8
- Partials 488 505 +17 ☔ View full report in Codecov by Sentry. |
b21f362 to
e7820f1
Compare
a1bea66 to
db7c64a
Compare
PermissionError in the mkdir method of LocalStreamFlowPathSingularityConnector
8c05dac to
4a6edc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit uses
SingularityConnectorattributes to retrieve bind paths on the container. Before this commit, the connector relied exclusively onproc_info_mountinfolinux file, which can fail to correctly resolve binds when the source path is a mounted volume on the host.