Skip to content

Comments

Fixed retrieving disk information in SingularityConnector#894

Open
LanderOtto wants to merge 2 commits intomasterfrom
fix/mkdir-permission-err
Open

Fixed retrieving disk information in SingularityConnector#894
LanderOtto wants to merge 2 commits intomasterfrom
fix/mkdir-permission-err

Conversation

@LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Dec 10, 2025

This commit uses SingularityConnector attributes to retrieve bind paths on the container. Before this commit, the connector relied exclusively on proc_info_mountinfo linux file, which can fail to correctly resolve binds when the source path is a mounted volume on the host.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 22.22222% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.96%. Comparing base (e0aea10) to head (db7c64a).
⚠️ Report is 22 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
streamflow/deployment/connector/container.py 22.22% 20 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   72.73%   72.96%   +0.23%     
==========================================
  Files          90       91       +1     
  Lines       12089    12226     +137     
  Branches     2125     2158      +33     
==========================================
+ Hits         8793     8921     +128     
+ Misses       2808     2800       -8     
- Partials      488      505      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LanderOtto LanderOtto marked this pull request as draft December 10, 2025 20:39
@GlassOfWhiskey GlassOfWhiskey force-pushed the master branch 7 times, most recently from b21f362 to e7820f1 Compare January 12, 2026 08:25
@LanderOtto LanderOtto force-pushed the fix/mkdir-permission-err branch from a1bea66 to db7c64a Compare January 13, 2026 17:00
@LanderOtto LanderOtto changed the title Fixed PermissionError in the mkdir method of LocalStreamFlowPath Fixed retrieving disk information in SingularityConnector Jan 13, 2026
@LanderOtto LanderOtto marked this pull request as ready for review January 13, 2026 18:42
@GlassOfWhiskey GlassOfWhiskey force-pushed the master branch 4 times, most recently from 8c05dac to 4a6edc9 Compare January 24, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant