Handle single-element list for CWL Workflow outputs#884
Draft
LanderOtto wants to merge 3 commits intomasterfrom
Draft
Handle single-element list for CWL Workflow outputs#884LanderOtto wants to merge 3 commits intomasterfrom
LanderOtto wants to merge 3 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #884 +/- ##
==========================================
+ Coverage 73.72% 73.75% +0.02%
==========================================
Files 91 91
Lines 12281 12287 +6
Branches 2156 2157 +1
==========================================
+ Hits 9054 9062 +8
+ Misses 2714 2713 -1
+ Partials 513 512 -1 ☔ View full report in Codecov by Sentry. |
ac48c95 to
6e24f0f
Compare
b21f362 to
e7820f1
Compare
8c05dac to
4a6edc9
Compare
…e `TokenProcessor`. This fix aligns the StreamFlow behavior with the cwltool reference implementation. Similar fix to #672
6e24f0f to
149011e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a special case of the
pickValuedirective. As defined in https://www.commonwl.org/v1.2/Workflow.html#WorkflowStepInput, if thepickValuehas a single source and the resulting list contains only one element (i.e., the source is not null), the element itself is returned, rather than a single-element list.