Draft
Conversation
LanderOtto
reviewed
Nov 11, 2024
| ) | ||
| ) | ||
| return await self.connector.run( | ||
| location=location if self.ephemeral else get_inner_location(location), |
Collaborator
There was a problem hiding this comment.
Suggested change
| location=location if self.ephemeral else get_inner_location(location), | |
| location=get_inner_location(location), |
| ) | ||
| # Populate instance | ||
| await self._populate_instance(self.instanceName) | ||
| sif_exists = returncode == 1 |
Collaborator
There was a problem hiding this comment.
Suggested change
| sif_exists = returncode == 1 | |
| sif_exists = returncode == 0 |
ff31760 to
926fc89
Compare
587901f to
84ebf3d
Compare
9660fdc to
90a078e
Compare
84ebf3d to
e038d8e
Compare
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
b21f362 to
e7820f1
Compare
ad4da9e to
256e723
Compare
8c05dac to
4a6edc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.