Changed scheduling Policy interface to take batch jobs in input#418
Draft
LanderOtto wants to merge 12 commits intomasterfrom
Draft
Changed scheduling Policy interface to take batch jobs in input#418LanderOtto wants to merge 12 commits intomasterfrom
Policy interface to take batch jobs in input#418LanderOtto wants to merge 12 commits intomasterfrom
Conversation
…er. However, list is not hashable, so now it is frozen
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
308
to
315
| # for path, size in deployment_hw.storage.items(): | ||
| # # todo: it is not really correct. They can have the same starts but be in different volumes | ||
| # # e.g. / -> volume1 and /mnt/data -> volume2 | ||
| # if job.tmp_directory.startswith(path): | ||
| # size -= hw_requirement.tmp_dir_size | ||
| # elif job.output_directory.startswith(path): | ||
| # size -= hw_requirement.output_dir_size | ||
| # storage[path] = size |
Check notice
Code scanning / CodeQL
Commented-out code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
==========================================
+ Coverage 69.99% 70.32% +0.33%
==========================================
Files 83 83
Lines 10591 10601 +10
Branches 2505 2490 -15
==========================================
+ Hits 7413 7455 +42
+ Misses 2728 2700 -28
+ Partials 450 446 -4 ☔ View full report in Codecov by Sentry. |
LanderOtto
force-pushed
the
feat/scheduler
branch
from
d33094e to
046d280
Compare
LanderOtto
force-pushed
the
feat/scheduler
branch
from
046d280 to
a6c78da
Compare
GlassOfWhiskey
force-pushed
the
master
branch
2 times, most recently
from
9660fdc to
90a078e
Compare
GlassOfWhiskey
force-pushed
the
master
branch
7 times, most recently
from
b21f362 to
e7820f1
Compare
GlassOfWhiskey
force-pushed
the
master
branch
4 times, most recently
from
8c05dac to
4a6edc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the
Policyinterface to take in input batch of jobs. Prior this commit, it was passed one job at time. Instead, a global vision of all the pending jobs allows to implement more sophisticated scheduling strategies.This change involves the entire
Schedulerclass.