Add keyboard navigation history similar to ranger #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allgreed
requested changes
Nov 10, 2020
Owner
There was a problem hiding this comment.
Very nice work -> clear and concise! If we can only move the UI from the core I'd say it's a very merge-worthy PR ;)
Also: (might not be applicable directly here, we'd probably lika a separate patch + some discussion before) I'm starting to abhor this root/non-root distinction in the UI. Like if we could have 2 classes - one regular and one for root - so that the main code is not sprinkled with if root checks ;)
| // TODO: how about children being Sets? | ||
| children: TreeNode<T>[]; | ||
| data: T; | ||
| lastSelectedChild: NodeID | null; |
Owner
There was a problem hiding this comment.
Aside for my hatred for nulls -> this most definitely does not belong in the core, since it's a UI matter => but the same logic injected into UI Node would de most definitely sensible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.