Made quick-ng-repeat work with jshint#23
Open
Rastii wants to merge 1 commit intoallaud:masterfrom
Rastii:jshint-compatibility
Open
Made quick-ng-repeat work with jshint#23Rastii wants to merge 1 commit intoallaud:masterfrom Rastii:jshint-compatibility
Rastii wants to merge 1 commit intoallaud:masterfrom
Rastii:jshint-compatibility
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I attempted to add this module into an existing angular project, I noticed a ton of errors/warnings using JSHint.
This pull request simply makes JSHint not scream at the code with the following changes:
As for the function declarations within loops, please let me know if I should change them, I honestly didn't review the code to a full extent; therefore, I wouldn't know the best naming conventions for said anonymous functions.
Thanks!