Open
Conversation
Owner
|
I'll check it in the next couple of days |
Owner
|
@llchan can you also add these changes to the quick-ng-script in example directory? |
Owner
|
Hey @llchan what about my suggestion? I want to merge this as soon as possible |
Author
|
Should I just update the example to be functionally the same but have an interpolated list name internally? In practice you probably wouldnt use it unless you have at least 2 lists to render but I dont know if we want to change up the example so much. |
Owner
|
@llchan actually we don't. Let's just make it the same file |
|
If I manually merge this should this support a nested ng-repeat too ? Because the below snippet doesn't work for me (with or without manually merging this PR) <div ng-repeat="item in mylist">
<div quick-ng-repeat="child in list" quick-repeat-list="item.children">{{ child.title }}</div>
</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds simple interpolation of the quick-repeat-list variable. There may be a better way to do this but this worked for my case. It is important to note that the variable is not watched like a typical interpolated attribute. We may want to add that option in the future.
#9