Skip to content

Cleanup and LMID updates #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vkaushal288-alivecor wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cleanup and LMID updates #5

vkaushal288-alivecor wants to merge 2 commits into from

Conversation

@vkaushal288-alivecor
Copy link

@vkaushal288-alivecor vkaushal288-alivecor commented Mar 26, 2025

Two main changes:

  1. Updated the error messages with LMIDs. I found that having the same error message for checksum verification failure for all block types was causing a small problem with debugging the failures.
  2. Removed a test package which we were depending upon. We had just 3 assertions in total. Importing a full third party library for just that looked like an overdo for the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jarredAC jarredAC jarredAC approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vkaushal288-alivecor @jarredAC