chore(execd): replace logger with internal package #237
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0866929076
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| COPY go.mod go.sum ./ | ||
| # Prepare local modules to satisfy replace directives. | ||
| COPY components/internal/go.mod components/internal/go.sum ./components/internal/ |
There was a problem hiding this comment.
This COPY components/... path assumes the build context is the repository root, but the current callers still build from components/execd (for example scripts/python-e2e.sh, scripts/java-e2e.sh, scripts/javascript-e2e.sh, and components/execd/build.sh all run docker build ... . after cd components/execd). In that context, components/internal/... is outside the build context, so Docker fails during COPY and the execd image can no longer be built in local or CI flows.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Nice suggestion, fixed this
|
/gemini review |
|
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
Pangjiping
force-pushed
the
feat/execd/logger
branch
from
0866929 to
06c9092
Compare
Pangjiping
force-pushed
the
feat/execd/logger
branch
from
06c9092 to
ba65c10
Compare
| COPY . . | ||
| # Copy sources. | ||
| COPY components/internal ./components/internal | ||
| COPY components/execd/. ./components/execd |
There was a problem hiding this comment.
COPY components/execd/. here is a little bit strange, use COPY components/execd directly?
3 participants
Summary
Testing
Breaking Changes
Checklist