fix: use posixpath for container internal paths #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaces os.path with posixpath for paths used inside containers to ensure forward slashes are used regardless of the host OS (fixing Windows support). - Adds unit tests to verify container internal paths. - Formats code and optimizes imports in docker.py.
hittyt
requested review from
Generalwin,
Pangjiping and
jwx0925
as code owners
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
|
add a windows e2e job in real-e2e.yml |
Collaborator
just add |
Pangjiping
previously approved these changes
Feb 12, 2026
- Adds windows-latest to the OS matrix in server-test.yml. - Sets bash as the default shell for cross-platform command compatibility. - Ensures unit tests (including Windows path fixes) are validated on both Linux and Windows environments.
- Updates API schema to allow Windows drive letter paths. - Enhances ensure_valid_host_path validator to correctly handle Windows absolute paths and drive letters. - Normalizes path separators during security checks to prevent bypasses. - Adjusts tests to be cross-platform compatible.
- Wraps delete_context calls in managed_ctx with asyncio.wait_for. - Prevents dead containers or network issues from blocking the test suite indefinitely.
- Adds runWithTimeout helper to prevent hanging runCode calls from blocking tests indefinitely. - Updates multi-language isolation tests to use this timeout. - Relaxes interrupt event validation to expect at least one terminal event instead of an exact XOR.
- Adds explicit timeouts and exception handling for code interrupt operations. - Prevents tests from hanging when SSE streams are abruptly closed by the server after an interrupt. - Relaxes result object validation to favor event-based verification after an interrupt.
- Corrects logger.warning() to logger.warn() to match SLF4J/Log4j API.
Pangjiping
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Breaking Changes
Checklist