osep: add OSEP-0005 fast-sandbox runtime support #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengcone
requested review from
Generalwin,
Pangjiping,
Spground,
hittyt,
jwx0925,
kevinlynx and
ninan-nn
as code owners
hittyt
reviewed
Feb 11, 2026
| ```python | ||
| # From fast-sandbox internal/controller/agentpool/registry.go | ||
|
|
||
| def Allocate(sandbox) -> AgentInfo: |
Collaborator
There was a problem hiding this comment.
Why not show the allocate logic using golang directly, since this happens in the fast sandbox controller?
| candidates.append((agent, score)) | ||
|
|
||
| # Select lowest score (prefers cached images) | ||
| return min(candidates, key=lambda x: x[1])[0] |
Collaborator
There was a problem hiding this comment.
What if no candidates available?
| continue | ||
| if agent.allocated >= agent.capacity: | ||
| continue | ||
| if not agent.has_available_port(sandbox.ports): |
Collaborator
There was a problem hiding this comment.
In some scenarios, we have no idea which ports will be used for a given sandbox.
And this do increase the ports conflict issue to the sandbox running phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Breaking Changes
Checklist