Open
Conversation
Collaborator
|
Hey @phuang07 , Thank you for this PR. We're going to discuss internally if this is something we want to add by default in the API client, as it would require a change in other API clients as well and there are some edge cases to think about. For the time being, you can work around this in your own code by setting a custom header with the API client when setting it up. This would allow you to add the referrer by default, and would unblock you right away. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Add "referer" header before sending out request.
What problem is this fixing?
In order to prevent Algolia indexing from dev instances, we need a way to restrict indexing from only the live site.
Algolia provides a feature for API restriction, which can be used to restrict a site to interact with the index by defining a narrow privilege API.
However, this feature requires to set the referer header in order to work, the site has to send the "referer" header along with the request.
Currently, this module doesn't set the referer header. This patch fixes this by adding adding header, the referer, before sending out the request.