Skip to content
This repository was archived by the owner on Jul 27, 2020. It is now read-only.

Comments

Feat: add 4 features #13

Draft
TomKlotzPro wants to merge 139 commits intomasterfrom
feat/first
Draft

Feat: add 4 features #13
TomKlotzPro wants to merge 139 commits intomasterfrom
feat/first

Conversation

@TomKlotzPro
Copy link
Contributor

Description

This pull request is related to this proposal.

What it changes

This helper will add 4 features :

  • Exists method
  • Count Method
  • Html Splitter
  • Generate Settings

TomKlotzPro and others added 30 commits May 20, 2019 13:06
@TomKlotzPro TomKlotzPro force-pushed the feat/first branch 12 times, most recently from 33e6128 to 6f65ab2 Compare July 3, 2019 12:44
@TomKlotzPro TomKlotzPro force-pushed the feat/first branch 3 times, most recently from e642a2b to 889256a Compare July 3, 2019 14:53
@TomKlotzPro
Copy link
Contributor Author

TomKlotzPro commented Jul 4, 2019

Until we don't take hand on API Key Dealer Travis CI. Travis will fail. cc @nunomaduro

@TomKlotzPro TomKlotzPro force-pushed the feat/first branch 3 times, most recently from 8124c64 to ff31640 Compare July 8, 2019 13:39
@nunomaduro
Copy link

@TomKlotzPro Let's discuss the api key dealer tomorrow.

Copy link

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor details, overall the pull request is impressive.

@TomKlotzPro TomKlotzPro force-pushed the feat/first branch 2 times, most recently from cc185af to 09820f3 Compare July 10, 2019 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants