Randomseed #257
Draft
Randomseed #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the enhancements! Suggestions:
|
vneiger
reviewed
Dec 22, 2025
Co-authored-by: Vincent Neiger <vneiger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the possibility for the user to give the seed to initialize the pseudo-random number generator with option -a (like alea). If 0 is given, then time(0) is used as before. Otherwise, the given positive number N is used.
Observe that the latter should only be used for debug purpose only.
It also cleans the code as only one call to srand is performed now.
A bug was introduced in positive characteristic with No more random linear form over Q #249 where the introduction of a random linear form would make msolve quit at some point without outputting the result. This PR fixes this behaviour.