Fix overflow on data duplication with elimination order #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When computing Gröbner basis with respect to an elimination ordering,
leadmons[0]is initialized as an array of sizenum_gb[0] * (bht->nv - st->nev).msolve/src/msolve/lifting-gb.c
Lines 755 to 770 in 8f84271
However,
duplicate_data_mthread_tracesupposes thatleadmons[0]is of sizenum_gb[0] * (st->nvars).msolve/src/msolve/duplicate.c
Line 149 in 8f84271
This causes undefined behavior on Line 162 below. On one of my machines, the line causes segmentation fault on
input_files/henrion5-qq.msfor j between the two values, with a probability of about 5%.msolve/src/msolve/duplicate.c
Lines 158 to 164 in 8f84271
This PR fixes the issue on my machine.