Skip to content

Add support for FreeBSD+ARM64.#186

Open
alexdlaird wants to merge 9 commits intomainfrom
freebsd-arm64
Open

Add support for FreeBSD+ARM64.#186
alexdlaird wants to merge 9 commits intomainfrom
freebsd-arm64

Conversation

@alexdlaird
Copy link
Owner

Description

This PR can be merged when ngrok starts publishing the ARM64 binary for FreeBSD (which they've said they plan to in the near future).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a schema change
  • This change requires a documentation update

Testing Done

There is a test that iterates over all items in this list, so the status checks for this PR will begin to pass as soon as ngrok makes the URI available.

Checklist

  • I have added tests that prove my change works as expected, and make test passes with no new errors or warnings
  • I have run make check to ensure no new errors or warnings
  • I have updated the docs, if applicable, and run make docs to ensure no new errors or warnings
  • I have performed a self-review of my own code
  • I have commented my code in particularly hard-to-understand areas

@codecov
Copy link

codecov bot commented Aug 18, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
120 1 119 0
View the top 1 failed test(s) by shortest run time
com.github.alexdlaird.ngrok.installer.NgrokInstallerTest::testEnsureInstallerUrlsExistV3()
Stack Traces | 1.11s run time
org.opentest4j.AssertionFailedError: Installer URL returned 404: https://bin.equinox..../c/bNyj1mQVY4c/ngrok-v3-stable-freebsd-arm64.zip ==> expected: <200> but was: <404>
	at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at app//org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
	at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:563)
	at app//com.github.alexdlaird.ngrok.installer.NgrokInstallerTest.testEnsureInstallerUrlsExistV3(NgrokInstallerTest.java:419)
	at java.base@21.0.9/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base@21.0.9/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base@21.0.9/java.util.ArrayList.forEach(ArrayList.java:1596)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for FreeBSD on ARM64 architecture by adding a new enum value to the NgrokV3CDNUrl enum. The change enables ngrok installation on FreeBSD systems running on ARM64 processors.

  • Adds FREEBSD_x86_64_arm enum value for FreeBSD ARM64 binary support
  • Updates the enum to include the appropriate download URL for the FreeBSD ARM64 binary

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexdlaird alexdlaird added the ready Issue has been triaged and accepted, ready to work label Aug 18, 2025
@github-actions github-actions bot added the stale Issue will be closed automatically if no further activity occurs label Sep 2, 2025
Repository owner deleted a comment from github-actions bot Sep 2, 2025
@alexdlaird alexdlaird added wip Work in progress, will be ignored by stale bot and removed stale Issue will be closed automatically if no further activity occurs labels Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Issue has been triaged and accepted, ready to work wip Work in progress, will be ignored by stale bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants