Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for FreeBSD on ARM64 architecture by adding a new enum value to the NgrokV3CDNUrl enum. The change enables ngrok installation on FreeBSD systems running on ARM64 processors.
- Adds FREEBSD_x86_64_arm enum value for FreeBSD ARM64 binary support
- Updates the enum to include the appropriate download URL for the FreeBSD ARM64 binary
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR can be merged when ngrok starts publishing the ARM64 binary for FreeBSD (which they've said they plan to in the near future).
Type of Change
Testing Done
There is a test that iterates over all items in this list, so the status checks for this PR will begin to pass as soon as ngrok makes the URI available.
Checklist
make testpasses with no new errors or warningsmake checkto ensure no new errors or warningsmake docsto ensure no new errors or warnings