Skip to content

Conversation

@alex-amenos
Copy link
Owner

@alex-amenos alex-amenos commented Nov 23, 2025

⚡️ Proposed Changes

  • Updates Jetpack Compose Nav3
  • Updates Koin
  • Updates other libraries

ℹ️ Additional Info

  • Add any additional useful context or info

🔗 Related Links

  • Add helpful links for this pull request

✅ Checklist

  • Unit Tests
  • Integration Tests
  • Compose Tests
  • Screenshot Tests
  • Updated string
  • Manually tested

📷 Screenshots

@alex-amenos alex-amenos self-assigned this Nov 23, 2025
Copilot AI review requested due to automatic review settings November 23, 2025 22:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates multiple third-party libraries including Gradle, Nav3 navigation library, Koin dependency injection framework, and various AndroidX components. The changes include a major migration from Koin 3.x to 4.x with corresponding API updates, upgrading Nav3 from alpha to stable versions, and updating AndroidX libraries to newer releases. The snapshot repository dependency has been removed as the libraries have progressed to more stable releases.

Key changes:

  • Upgraded Koin from 3.x to 4.1.1 and migrated from deprecated getViewModel() to koinViewModel() API
  • Updated Nav3 from alpha to stable (1.0.0) and migrated decorators to new APIs
  • Updated AndroidX libraries (Activity, Core-KTX, Lifecycle, Compose) to newer versions

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
settings.gradle Removed AndroidX snapshot repository as libraries moved to stable releases
gradle/wrapper/gradle-wrapper.properties Updated Gradle wrapper to version 8.14.3
gradle/libs.versions.toml Updated multiple library versions including Koin 4.1.1, Nav3 1.0.0, AndroidX lifecycle 2.10.0, and compose BOM
feature/settings/src/main/java/com/alxnophis/jetpack/settings/ui/navigation/SettingsNavGraph.kt Migrated from getViewModel to koinViewModel for Koin 4.x compatibility
feature/root/src/main/java/com/alxnophis/jetpack/root/ui/navigation/Navigation.kt Updated Nav3 decorators and removed deprecated APIs
feature/posts/src/main/java/com/alxnophis/jetpack/posts/ui/composable/PostsFeature.kt Migrated from getViewModel to koinViewModel
feature/posts/src/main/java/com/alxnophis/jetpack/posts/ui/composable/PostDetailFeature.kt Migrated from getViewModel to koinViewModel
feature/my-playground/src/main/java/com/alxnophis/jetpack/myplayground/ui/composable/MyPlaygroundFeature.kt Migrated from getViewModel to koinViewModel
feature/location-tracker/src/main/java/com/alxnophis/jetpack/location/tracker/ui/composable/LocationTrackerFeature.kt Migrated from getViewModel to koinViewModel
feature/home/src/main/java/com/alxnophis/jetpack/home/ui/composable/HomeFeature.kt Migrated from getViewModel to koinViewModel
feature/game/ballclicker/src/main/java/com/alxnophis/jetpack/game/ballclicker/ui/composable/BallClickerFeature.kt Migrated from getViewModel to koinViewModel
feature/file-downloader/src/main/java/com/alxnophis/jetpack/filedownloader/ui/composable/FileDownloaderFeature.kt Migrated from getViewModel to koinViewModel
feature/authentication/src/main/java/com/alxnophis/jetpack/authentication/ui/composable/AuthenticationFeature.kt Migrated from getViewModel to koinViewModel

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Nov 23, 2025

@alex-amenos I've opened a new pull request, #149, to work on those changes. Once the pull request is ready, I'll request review from you.

@alex-amenos alex-amenos merged commit f14e8e5 into main Nov 23, 2025
1 check passed
@alex-amenos alex-amenos deleted the refactor/lib_updates branch November 23, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants