-
Notifications
You must be signed in to change notification settings - Fork 0
[REFACTOR] Update 3rd party libs #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…erences from settings.gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates multiple third-party libraries including Gradle, Nav3 navigation library, Koin dependency injection framework, and various AndroidX components. The changes include a major migration from Koin 3.x to 4.x with corresponding API updates, upgrading Nav3 from alpha to stable versions, and updating AndroidX libraries to newer releases. The snapshot repository dependency has been removed as the libraries have progressed to more stable releases.
Key changes:
- Upgraded Koin from 3.x to 4.1.1 and migrated from deprecated
getViewModel()tokoinViewModel()API - Updated Nav3 from alpha to stable (1.0.0) and migrated decorators to new APIs
- Updated AndroidX libraries (Activity, Core-KTX, Lifecycle, Compose) to newer versions
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle | Removed AndroidX snapshot repository as libraries moved to stable releases |
| gradle/wrapper/gradle-wrapper.properties | Updated Gradle wrapper to version 8.14.3 |
| gradle/libs.versions.toml | Updated multiple library versions including Koin 4.1.1, Nav3 1.0.0, AndroidX lifecycle 2.10.0, and compose BOM |
| feature/settings/src/main/java/com/alxnophis/jetpack/settings/ui/navigation/SettingsNavGraph.kt | Migrated from getViewModel to koinViewModel for Koin 4.x compatibility |
| feature/root/src/main/java/com/alxnophis/jetpack/root/ui/navigation/Navigation.kt | Updated Nav3 decorators and removed deprecated APIs |
| feature/posts/src/main/java/com/alxnophis/jetpack/posts/ui/composable/PostsFeature.kt | Migrated from getViewModel to koinViewModel |
| feature/posts/src/main/java/com/alxnophis/jetpack/posts/ui/composable/PostDetailFeature.kt | Migrated from getViewModel to koinViewModel |
| feature/my-playground/src/main/java/com/alxnophis/jetpack/myplayground/ui/composable/MyPlaygroundFeature.kt | Migrated from getViewModel to koinViewModel |
| feature/location-tracker/src/main/java/com/alxnophis/jetpack/location/tracker/ui/composable/LocationTrackerFeature.kt | Migrated from getViewModel to koinViewModel |
| feature/home/src/main/java/com/alxnophis/jetpack/home/ui/composable/HomeFeature.kt | Migrated from getViewModel to koinViewModel |
| feature/game/ballclicker/src/main/java/com/alxnophis/jetpack/game/ballclicker/ui/composable/BallClickerFeature.kt | Migrated from getViewModel to koinViewModel |
| feature/file-downloader/src/main/java/com/alxnophis/jetpack/filedownloader/ui/composable/FileDownloaderFeature.kt | Migrated from getViewModel to koinViewModel |
| feature/authentication/src/main/java/com/alxnophis/jetpack/authentication/ui/composable/AuthenticationFeature.kt | Migrated from getViewModel to koinViewModel |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@alex-amenos I've opened a new pull request, #149, to work on those changes. Once the pull request is ready, I'll request review from you. |
…with ImmutableList for posts in UI state and related components
…ack, chucker, and kotest
⚡️ Proposed Changes
ℹ️ Additional Info
🔗 Related Links
✅ Checklist
📷 Screenshots