feat(crossmatch): integrate XWave cone search service#418
Open
dirodriguezm wants to merge 1 commit intomainfrom
Open
feat(crossmatch): integrate XWave cone search service#418dirodriguezm wants to merge 1 commit intomainfrom
dirodriguezm wants to merge 1 commit intomainfrom
Conversation
Contributor
dirodriguezm
commented
Oct 13, 2025
dirodriguezm
commented
- Add XWave client with cone search functionality
- Create service layer for XWave integration
- Update crossmatch route to use XWave cone search
- Add XWave URL configuration support
- Implement dependency injection for cone search queries
- Update templates to display XWave-powered results with attribution
- Remove global USE_ABSOLUTE environment variable in favor of service-specific config
AlxEnashi
reviewed
Oct 15, 2025
| from db_plugins.db.sql._connection import PsqlDatabase | ||
| from fastapi import Depends | ||
|
|
||
| from crossmatch_api.services.xwave_client import client |
Contributor
There was a problem hiding this comment.
Solo se usa consearch de este archivo, por que no importarlo directo y usarlo directo.
En lugar de
from crossmatch_api.services.xwave_client import client
from crossmatch_api.services.xwave_client.client import consearch
(o importar consearch en init y se puede importar mas directo, hay formas)
AlxEnashi
reviewed
Oct 15, 2025
| from .connection import ApiDatabase | ||
|
|
||
| db_dependency = Annotated[PsqlDatabase, Depends(ApiDatabase)] | ||
| xwave_conesearch_dependency = Annotated[ConesearchQuery, Depends(lambda: client.conesearch)] |
Contributor
There was a problem hiding this comment.
porque esa depended necesita una funcion que retorna una funcion?
Contributor
Author
There was a problem hiding this comment.
No me funcionó usando directamente la función. Pero si lo meto como lambda funciona
AlxEnashi
approved these changes
Oct 15, 2025
Contributor
AlxEnashi
left a comment
AlxEnashi
left a comment
There was a problem hiding this comment.
Salvo ese detalle del dependencies me parece todo bien.
Sorry la demora
- Add XWave client with cone search functionality - Create service layer for XWave integration - Update crossmatch route to use XWave cone search - Add XWave URL configuration support - Implement dependency injection for cone search queries - Update templates to display XWave-powered results with attribution - Remove global USE_ABSOLUTE environment variable in favor of service-specific config
dirodriguezm
force-pushed
the
feat/xwave
branch
from
0c42553 to
fe0a11c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.