State improvements + QoL additions#91
Open
0x96EA wants to merge 12 commits intoakuse-app:react-portfrom
Open
Conversation
added a storage hook for the frontend
used storage methods in some places
because why not
small fixes on main and app
also adding and remove shows from your list
cleaned up listeners and fixed up useEffects across the app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So i went down a rabbit hole to fix the app state not being saved correctly and learned a lot about electron store... Please feel free to choose to use parts of the PR or redo it in a style you want. 😊
I optimized the number of calls that needed to be made to the store and keep the data in a context with a hook for the frontend. Have already seen the performance improvements and the app now "remembers things correctly".
List of changes
useStorageContext()Screenshots
Skip Intro button moved to the left and Picture in picture button on the right
Picture in picture on
Picture in picture with mouse hovered over it