Skip to content

Avoid setting this.el to child node of element #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcbrand wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid setting this.el to child node of element #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db4e385
Avoid setting `this.el` to child node of element
jcbrand Mar 1, 2019
5997c81
Make sure underscore is loaded
jcbrand Mar 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions backbone.nativeview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
// https://github.com/akre54/Backbone.NativeView

(function (factory) {
if (typeof define === 'function' && define.amd) { define(['backbone'], factory);
} else if (typeof module === 'object') { module.exports = factory(require('backbone'));
} else { factory(Backbone); }
}(function (Backbone) {
if (typeof define === 'function' && define.amd) { define(['underscore', 'backbone'], factory);
} else if (typeof module === 'object') { module.exports = factory(require('underscore'), require('backbone'));
} else { factory(_, Backbone); }
}(function (_, Backbone) {
// Cached regex to match an opening '<' of an HTML tag, possibly left-padded
// with whitespace.
var paddedLt = /^\s*</;
Expand Down Expand Up @@ -87,7 +87,7 @@
} else {
this.el = document.querySelector(element);
}
} else if (element && element.length) {
} else if (element && !_.isElement(element) && element.length) {
this.el = element[0];
} else {
this.el = element;
Expand Down