Add stream state to stream frames #895
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Active stream metrics rely on being able to cancel out counters for open vs error | close, where open counters are triggered by
BEGINframes and error counters are triggered by eitherABORTorRESETframes.Due to the removal of stream handlers when sending
ABORTor receivingRESET, we do not double count these errors.However, there are edge cases where a reply
RESETcan be sent without a corresponding replyBEGIN, making it difficult to get the active count correct without introducing a lot of memory state during the metrics recording.Instead, we can acheive the same goal to expose metrics recording to stream state by encoding the stream state in each stream frame, as a bitset, which will also further assist with diagnostics.