Display all entity types for each entity#17
Open
philgooch wants to merge 8 commits intoajenhl:masterfrom
Open
Conversation
Entities may have more than one entity type - display each of them in whitespace-delimited list
Owner
|
Thank you for the patch. Could you please remove the commented out line of old code, and update oxygen/lib/eatslookup.jar and the files in oxygen/dist with ones built with your patched sources, and I'll merge it in. |
Owner
|
Sorry for the delay with this - I missed the notification. Also sorry for leading you astray about the dist and build material; this should not be added, just the oxygen/lib/eatslookup.jar. I saw the dist files in my working tree and assumed they were in the repository when they (properly) aren't. So if you could resubmit again with the commented out code change and the replaced oxygen/lib/eatslookup.jar, that would be great. |
This reverts commit e570569.
Syncing to upstream changes on master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entities may have more than one entity type - display each of them in
whitespace-delimited list