fix saving best test metrics#74
Open
mshahbazi72 wants to merge 1 commit intoajbrock:masterfrom
mshahbazi72:Mo
Open
fix saving best test metrics#74mshahbazi72 wants to merge 1 commit intoajbrock:masterfrom mshahbazi72:Mo
mshahbazi72 wants to merge 1 commit intoajbrock:masterfrom
mshahbazi72:Mo
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the test function in train_fns.py, when saving the best model based on best IS or FID, the best model is first saved, and then the state_dict is updated with the new best FID and IS values. Therefore, in the saved model's state_dict, the best FID and IS values of the previous best model is shown, instead of the current model.
This pull request will solve the issue by updating the best metrics in the state_dict before saving the best model.