Remove unsafe #184
Merged
Remove unsafe #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
approved these changes
Feb 1, 2026
|
|
||
| // Determine reference size based on UseCompressedOops | ||
| // Default is true for heaps < 32GB on 64-bit JVMs | ||
| boolean compressedOops = getBooleanVmOption(hotSpotBean, "UseCompressedOops", true); |
Member
There was a problem hiding this comment.
Is the flag textual value an integer?
Member
Author
There was a problem hiding this comment.
Yep, I wrote tests. booleans give you true/false, and number ones give you numbers.
Contributor
|
@dain before merging this can you release a snapshot so that we can benchmark this in Trino? |
JOL already did not work on records, and uses unsafe. Use HotSpotDiagnosticMXBean to query JVM options that determine object header sizes, use reflection to get field types, and handle alignment.
Member
Author
|
Sure, I published slice-2.5-20260202.012431-1. Please run the benchmarks soon, and if you seem a problem be specific. |
wendigo
added a commit
to trinodb/trino
that referenced
this pull request
Feb 2, 2026
Contributor
|
@dain testing here: trinodb/trino#28075 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Slicecopy to/fromprimitive[].Performance Testing (MemorySegment conversion):
Benchmarked Slice.getLongs()/setLongs() comparing Unsafe.copyMemory vs MemorySegment.copy on JDK 25:
primitive[]copy operations.