Convert XxHash64 to VarHandle #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
sun.misc.UnsafewithVarHandlefor memory access in XxHash64.Changes
Unsafe.getLong/getInt/getBytewithVarHandle.get()Unsafe.copyMemorywithSystem.arraycopyhash(byte[])API for direct byte array hashingPerformance
Inlining the updateBody method in the implementation was necessary to avoid an 18% regression at 64 bytes with VarHandle. After inlining, performance is equivalent for the byte[] API. The Slice API has a slight regression
at 64 bytes (~1ns per invocation) which I suspect is due to interaction between VarHandle bounds checking and Slice wrapper methods.